feat: add react action-enforcement example with custom lint rule#1296
Draft
hugiex wants to merge 1 commit intoTanStack:mainfrom
Draft
feat: add react action-enforcement example with custom lint rule#1296hugiex wants to merge 1 commit intoTanStack:mainfrom
hugiex wants to merge 1 commit intoTanStack:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Follow up the issue: #996
Create an example and demonstrates two lint-based enforcement approaches for TanStack DB usage in feature/UI code.
There are two options:
1. Use existed rule - Strict Boundary Approach (no-restricted-imports)
This approach blocks feature modules from importing collections at all.
Policy: src/features/** cannot import @/db/collections/*
Effect: features must use action/query wrappers only
Pros: very strong architectural boundary, simple ESLint config
Cons: less ergonomic for read paths (useLiveQuery often requires extra wrapper hooks)
2. Targeted Mutation Approach (Custom ESLint Rule)
This approach allows collection imports for reads, but forbids direct mutation calls in feature code.
Policy: in src/features/**, direct calls to collection mutation methods are forbidden (insert, update, delete, upsert)
Effect: useLiveQuery with direct collection imports remains allowed; writes must go through centralized boundaries (actions/hooks)
Pros: better DX for reads, enforces the core safety rule on writes
Cons: more implementation complexity (custom plugin/rule)
NOTE: this PR just for example, DO NOT merge this
✅ Checklist
pnpm test.🚀 Release Impact