Consolidates all mcp tools to take frameworks as arguments #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jherr
approved these changes
Jun 5, 2025
DogPawHat
reviewed
Jun 9, 2025
| @@ -24,7 +24,7 @@ export function createFrameworkDefinition(): FrameworkDefinition { | |||
|
|
|||
| return { | |||
| id: 'react-cra', | |||
| name: 'react', | |||
| name: 'React', | |||
There was a problem hiding this comment.
This is the cause of #119
We're passing in lower case 'react' into the getFrameworkByName function and it breaks because it's case senstive.
jherr
pushed a commit
that referenced
this pull request
Jun 9, 2025
|
Mind blowing reactivity guys. Highly appreciated ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the MCP tools work across frameworks, reducing the number of tools an agent needs to create Tanstack applications. This is important because Agents work better with 5-6 tools. (Two for every JS framework isn't ideal!)
Closes #101