fix: update cloudflare's wrangler.json to wrangler.jsonc#204
Merged
tannerlinsley merged 1 commit intoTanStack:mainfrom Oct 20, 2025
Merged
fix: update cloudflare's wrangler.json to wrangler.jsonc#204tannerlinsley merged 1 commit intoTanStack:mainfrom
wrangler.json to wrangler.jsonc#204tannerlinsley merged 1 commit intoTanStack:mainfrom
Conversation
| @@ -3,8 +3,5 @@ | |||
| "name": "tanstack-start-app", | |||
| "compatibility_date": "2025-09-02", | |||
| "compatibility_flags": ["nodejs_compat"], | |||
| "main": "@tanstack/react-start/server-entry", | |||
| "vars": { | |||
| "MY_VAR": "Hello from Cloudflare" | |||
Contributor
Author
There was a problem hiding this comment.
This variable is unused to I figured we can just remove it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloudflare recommends using a jsonc file instead of a json one
This is also relevant here since we want to enable the create-cloudflare CLI (C3) to create tanstack start application (by calling the tanstack cli) and C3 appends comments to wrangler configuration files, meaning that these will show up as erroneous if a json file is used instead of jsonc