Skip to content

[codex] Replace Practice Notebook with Useful Phrases - #87

Merged
Talljack merged 7 commits into
mainfrom
codex/useful-phrases
Jul 15, 2026
Merged

Talljack merged 7 commits into
mainfrom
codex/useful-phrases

Conversation

@Talljack

Copy link
Copy Markdown
Owner

What changed

  • replace Practice Notebook with a flat Useful Phrases library
  • preserve legacy journal turns as useful phrases
  • support manual entry, details, tags, search, editing, favorites, practice actions, and deletion
  • save selected page text directly to Useful Phrases
  • redirect legacy journal detail links and remove whole-conversation notebook saving
  • isolate phrase tags and generated practice content per phrase
  • add English and Chinese localization

Why

Practice Notebook stored whole conversations, while the desired workflow is capturing reusable expressions such as “It's taken.” for later practice.

Validation

  • journal store tests: 11 passed
  • Useful Phrases component tests: 3 passed
  • selection popup tests: 2 passed
  • pnpm typecheck
  • pnpm lint
  • pnpm build
  • browser-tested desktop and 390px mobile flows, duplicate normalization, details, filtering, editing, favorites, practice navigation, selection saving, deletion, and legacy redirect

@vercel

vercel Bot commented Jul 15, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
echo-type Ready Ready Preview, Comment Jul 15, 2026 1:37am

@Talljack
Talljack marked this pull request as ready for review July 15, 2026 01:36
@Talljack
Talljack merged commit 52440e4 into main Jul 15, 2026
6 checks passed
@Talljack
Talljack deleted the codex/useful-phrases branch July 15, 2026 01:37

This branch was successfully deployed

1 active deployment
Preview — d22e3aeb Deployed Jul 15, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant