Repository navigation
[codex] Add practice notebook journal flow - #80
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/journalPractice Notebook flow with list/detail pages, manual creation, import dialog, editable entry rows, highlighting, and whole-notebook practice materialization.speakeris now optional free text, so entries can be unlabeled phrases, A/B dialogue lines, Speak exports, or any custom label.SaveToJournalButton, including iOS native-host visibility and a guard that requires a real user message before saving.Why
The original notebook design assumed every saved item was a strict dialogue turn. Real learning material can be single phrases, unlabeled sentences, A/B scripts, lesson notes, or conversations exported from Speak. This PR makes the notebook model match those actual use cases while keeping Speak -> Save compatible.
Validation
pnpm typecheckpnpm test src/lib/journal-structure.test.ts src/components/journal/save-to-journal-button.test.tsx src/stores/__tests__/journal-store.test.tspnpm exec biome check src/lib/journal-structure.test.ts src/lib/journal-structure.ts src/components/journal/import-dialog.tsx src/components/journal/journal-detail.tsx src/components/journal/journal-list.tsx src/components/journal/turn-row.tsx src/stores/journal-store.ts src/types/journal.tspnpm buildBrowser QA
Verified with
agent-browseragainst the local app:Useful Phrase Setfrom/journalvia the realNewdialog.A,B, andPhraselabels./journallist showsUseful Phrase Set 4 entriesand search matches the unlabeled line./speak, enteredOrdering Coffee, sent a user message, confirmedSavebecomes enabled, saved, and confirmed/journalshowsOrdering Coffee 3 entries #speak./api/journal/structure:Analyze -> editable free-label preview -> Save notebook -> detail page.