Skip to content

Fix favorites popup folder state and partial selections - #75

Merged
Talljack merged 3 commits into
mainfrom
codex/fix-favorites-folders-selection
Jun 11, 2026
Merged

Talljack merged 3 commits into
mainfrom
codex/fix-favorites-folders-selection

Conversation

@Talljack

Copy link
Copy Markdown
Owner

Summary

  • keep selection translation payloads anchored to the actual highlighted text instead of expanding partial selections
  • align favorites popup actions with current folder semantics, including move/remove states and related API coverage
  • update the listen e2e flow to verify the current popup UI, speech text, folder move interaction, and favorites page result

Verification

  • pnpm exec playwright test e2e/listen.spec.ts --grep "listen popup keeps partial selections scoped and favorite interactions stay in sync" --project=chromium
  • pnpm vitest run src/lib/tests/selection-translation-text.test.ts src/lib/tests/favorite-selection-action.test.ts
  • pre-commit hook: biome check --write --no-errors-on-unmatched
  • pre-commit hook: tsc --noEmit

@vercel

vercel Bot commented Jun 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
echo-type Ready Ready Preview, Comment Jun 11, 2026 1:38pm

@Talljack
Talljack merged commit 4d44aad into main Jun 11, 2026
6 checks passed
@Talljack
Talljack deleted the codex/fix-favorites-folders-selection branch June 11, 2026 13:42

This branch was successfully deployed

1 active deployment
Preview — 645b38ca Deployed Jun 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant