Skip to content

fix: preserve active provider state when switching settings - #29

Merged
Talljack merged 1 commit into
mainfrom
fix/provider-selection-settings-pr
Apr 7, 2026
Merged

Talljack merged 1 commit into
mainfrom
fix/provider-selection-settings-pr

Conversation

@Talljack

@Talljack Talljack commented Apr 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • disconnect the current active provider instead of the editing provider when switching settings
  • avoid retriggering disconnect side effects during hydration by syncing the editing id directly
  • add E2E coverage for switching between connected providers and reselecting the same provider

Verification

  • pnpm typecheck
  • pnpm exec playwright test e2e/settings.spec.ts

@vercel

vercel Bot commented Apr 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
echo-type Ready Ready Preview, Comment Apr 7, 2026 3:48pm

@Talljack
Talljack merged commit a3dc927 into main Apr 7, 2026
6 checks passed
@Talljack
Talljack deleted the fix/provider-selection-settings-pr branch April 7, 2026 23:51

This branch was successfully deployed

1 active deployment
Preview — 251698de Deployed Apr 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant