Repository navigation
fix: resolve Windows startup crash from Node entry path (#105) - #106
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #105.
Use relative
server.jswhen launching the bundled Node sidecar to avoid Windows verbatim-path resolution failures. Executable, working directory and environment remain unchanged.Add automated startup checks on pull requests and main pushes for Windows, macOS, Linux, production Web and native iOS simulator.
Issues found and fixed by verification
Final validation: 560168c
All startup checks passed on the current head:
Desktop/Web: https://github.com/Talljack/echo-type/actions/runs/34490025606
iOS: https://github.com/Talljack/echo-type/actions/runs/34490025466
Artifacts include screenshots, Windows/Linux test installers and iOS XCTest results/logs. Local smoke-harness tests also pass.
Scope and limits
Desktop page checks use separate Chromium against the bundled sidecar, not full embedded-window interaction. iOS uses an actual simulator WKWebView. These checks do not certify every OS/version/architecture, physical hardware, production signing, SmartScreen/Gatekeeper or external AI services. See docs/design/startup-verification.md.
No data migration, version bump, release publishing or merge performed.