Fix mysql deadlocks while reserving jobs #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljfranklin
force-pushed
the
PR-mysql-deadlocks
branch
from
4fa95cb to
6d03b16
Compare
Contributor
Author
|
@JonathanTron gentle bump on this. Not sure if this repo is still maintained, if not we can keep our fork going. Thanks! |
Member
|
Hi @ljfranklin, thanks for reporting the issue and providing a PR. We're not using MySQL at all, I'm willing to accept the PR, but could you do it like in the ActiveRecord version and only apply this fix if using MySQL? |
ljfranklin
force-pushed
the
PR-mysql-deadlocks
branch
from
6d03b16 to
b1b7440
Compare
- We frequently see deadlock errors when using mysql and a large number of workers - This PR adds a fix for the deadlocks as well as modifying a test to exposes the deadlock issue in the previous implementation - This implementation is based on the `reserve` implementation from the default active_record backend: https://github.com/collectiveidea/delayed_job_active_record/blob/42a68ed79917e14244a25a0a77fef0924bef3e97/lib/delayed/backend/active_record.rb#L64 - You can see the original error by pulling in the new test and running: `DEBUG=true DB=mysql bundle exec rspec spec/delayed/backend/sequel_spec.rb:27`
ljfranklin
force-pushed
the
PR-mysql-deadlocks
branch
from
b1b7440 to
3a90c72
Compare
Contributor
Author
|
@JonathanTron sure, pushed that update. And if you're curious, here's an overly long thread about people arguing about deadlocks in the active_record backend: collectiveidea/delayed_job_active_record#63. |
Member
|
@ljfranklin Thanks a lot for the fast action! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of workers
exposes the deadlock issue in the previous implementation
reserveimplementation from thedefault active_record backend:
https://github.com/collectiveidea/delayed_job_active_record/blob/42a68ed79917e14244a25a0a77fef0924bef3e97/lib/delayed/backend/active_record.rb#L64
DEBUG=true DB=mysql bundle exec rspec spec/delayed/backend/sequel_spec.rb:27