Skip to content

feat(QTDI-875): extend validation to object #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

undx
Copy link
Member

@undx undx commented Nov 22, 2024

This comment has been minimized.

Copy link
Contributor

@ozhelezniak-talend ozhelezniak-talend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of yes
But maybe we can check if the object is Datastore, Dataset, or object marked with an annotation that has type = "configuration"
it will be correct check.

@undx
Copy link
Member Author

undx commented Nov 25, 2024

Kind of yes But maybe we can check if the object is Datastore, Dataset, or object marked with an annotation that has type = "configuration" it will be correct check.

We already check the @Option annotation presence and don't restrict unless an object type. In fact, the "configuration" value for @Option is more a convention as values are never checked.

Copy link

sonar-eks bot commented Dec 10, 2024

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 77.78% Coverage (54.90% Estimated after merge)
  • Duplications 0.00% Duplicated Code (1.30% Estimated after merge)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

@undx undx merged commit ba49576 into master Dec 11, 2024
6 checks passed
@undx undx deleted the undx/QTDI-875-extend-dyndep-validation branch December 11, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants