Skip to content

feat(QTDI-597): remove GitHub in starter toolkit #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 55 commits into from
Dec 12, 2024

Conversation

undx
Copy link
Member

@undx undx commented Oct 28, 2024

https://qlik-dev.atlassian.net/browse/QTDI-597

this pull request is based on #904, please review only latest commit feat(QTDI-597): remove github export.

Copy link
Contributor

@ozhelezniak-talend ozhelezniak-talend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acatoire acatoire changed the title feat(QTDI-597): remove GitHub feat(QTDI-597): remove GitHub in starter toolkit Nov 15, 2024

This comment has been minimized.

1 similar comment

This comment has been minimized.

This comment has been minimized.

ypiel-talend
ypiel-talend previously approved these changes Dec 12, 2024
Copy link
Contributor

@ypiel-talend ypiel-talend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Conflicts:
#	component-starter-server/src/main/frontend/README.md
#	component-starter-server/src/main/frontend/backend/index.js
#	component-starter-server/src/main/frontend/package.json
#	component-starter-server/src/main/frontend/src/app/components/Finish/Finish.js
Copy link

sonar-eks bot commented Dec 12, 2024

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (55.20% Estimated after merge)
  • Duplications No duplication information (1.30% Estimated after merge)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

@undx undx merged commit f9dcf2c into master Dec 12, 2024
5 of 6 checks passed
@undx undx deleted the undx/QTDI-597-starter-toolkit-remove-github branch December 12, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants