Skip to content

chore(QTDI-2913): fix wrong condition#1229

Open
undx wants to merge 1 commit into
masterfrom
ouf/QTDI-2913-wrong-condition
Open

chore(QTDI-2913): fix wrong condition#1229
undx wants to merge 1 commit into
masterfrom
ouf/QTDI-2913-wrong-condition

Conversation

@undx
Copy link
Copy Markdown
Member

@undx undx commented May 28, 2026

https://qlik-dev.atlassian.net/browse/QTDI-2913

Requirements

  • Any code change adding any logic MUST be tested through a unit test executed with the default build
  • Any API addition MUST be done with a documentation update if relevant

Why this PR is needed?

What does this PR adds (design/code thoughts)?

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the custom Beam serialization path so top-level String values are serialized with the correct ObjectOutputStream.writeString branch instead of being treated as class descriptors.

Changes:

  • Removed the incorrect String.class.isInstance(obj) branch that invoked writeClassDesc.
  • Added a regression test covering SerializationWrapper.replace(...) with a top-level String.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/transformer/BeamIOTransformer.java Corrects serializer branching for String values.
component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/transformer/BeamIOTransformerTest.java Adds regression coverage for String serialization through SerializationWrapper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonar-rnd
Copy link
Copy Markdown

sonar-rnd Bot commented May 28, 2026

@undx undx requested a review from ozhelezniak-talend May 28, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants