chore(QTDI-1826): unblock CodeQL #1079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
* remove org.talend.ui:talend-icon:3.8.0 it's deprecated dependency, and its content is already inside the folder of documentation/src/main/antora/modules/ROOT/assets/images/icons/svg
ozhelezniak-talend
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated icon-related dependencies and configurations from the Maven build while adding a new snapshot plugin repository. The changes appear to be maintenance work to clean up unused dependencies and potentially resolve CodeQL analysis issues.
- Removes deprecated
talend-icondependency and related configuration from the documentation module - Adds a new Central Portal Snapshots plugin repository for snapshot dependencies
- Minor formatting improvement for a dependency comment
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pom.xml | Removes deprecated talend-icon version property and adds Central Portal Snapshots plugin repository |
| documentation/pom.xml | Removes talend-icon dependency and maven-dependency-plugin configuration for icon unpacking |
| component-runtime-testing/component-runtime-junit/pom.xml | Minor comment formatting improvement |
Comments suppressed due to low confidence (1)
pom.xml:998
- [nitpick] The repository ID 'central.portal' may be confusing as it doesn't clearly indicate this is for snapshots. Consider a more descriptive ID like 'central-snapshots' or 'sonatype-central-snapshots'.
<id>central.portal</id>
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
Analysis Details0 Issues
Coverage and Duplications
Project ID: org.talend.sdk.component:component-runtime |
ozhelezniak-talend
deleted the
ozhelezniak/QTDI-1826_add_snapshot_plugin_repo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Why this PR is needed?
What does this PR adds (design/code thoughts)?