Skip to content

chore(QTDI-1765): remove out-dated plugin #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ozhelezniak-talend
Copy link
Contributor

@ozhelezniak-talend ozhelezniak-talend commented Jul 24, 2025

  • replace its functionality with a community supported plugins
  • bump the version of spotless maven plugin

Requirements

  • Any code change adding any logic MUST be tested through a unit test executed with the default build
  • Any API addition MUST be done with a documentation update if relevant

Why this PR is needed?

What does this PR adds (design/code thoughts)?

* replace its functionality with a community supported plugins
Copilot

This comment was marked as outdated.

This comment has been minimized.

Copilot

This comment was marked as outdated.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the outdated common-maven-plugin from the project and replaces its functionality with community-supported alternatives. The PR also includes a version bump for the spotless maven plugin from 2.44.4 to 2.46.1.

  • Removal of common-maven-plugin dependency and configuration from all POM files
  • Replacement of plugin functionality with standard Maven plugins (maven-antrun-plugin and maven-resources-plugin)
  • Version upgrade of spotless-maven-plugin to 2.46.1

Reviewed Changes

Copilot reviewed 7 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pom.xml Removes common-maven-plugin property and configurations, updates spotless version, removes POM sorting configuration
documentation/pom.xml Replaces common-maven-plugin with maven-antrun-plugin and maven-resources-plugin for file filtering
component-tools-webapp/pom.xml Adds maven-antrun-plugin and maven-resources-plugin to replace common-maven-plugin functionality
component-starter-server/pom.xml Adds maven-antrun-plugin and maven-resources-plugin executions for frontend file processing
component-studio/pom.xml Removes common-maven-plugin configuration
talend-component-maven-plugin/src/it/dependency/pom.xml Removes common-maven-plugin configuration
component-runtime-testing/component-runtime-junit/pom.xml Minor comment formatting change

This comment has been minimized.

This comment has been minimized.

1 similar comment
Copy link

sonar-eks bot commented Jul 24, 2025

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (65.90% Estimated after merge)
  • Duplications 0.00% Duplicated Code (1.40% Estimated after merge)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

Copy link
Member

@undx undx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Did not find what was the purpose of the rootlocation value?!?

@ozhelezniak-talend
Copy link
Contributor Author

ozhelezniak-talend commented Jul 24, 2025

lgtm Did not find what was the purpose of the rootlocation value?!?

It was to set the value of the module directory inside the variable. The same as ${parent.dir}
image

@ozhelezniak-talend ozhelezniak-talend merged commit 0c844b0 into master Aug 1, 2025
6 of 7 checks passed
@ozhelezniak-talend ozhelezniak-talend deleted the ozhelezniak/QTDI-1765_remove_not_supported_maven_plugin branch August 1, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants