Menu items have no text on macOS

[Taitava]

Discussed in #313

^{Originally posted by breaker-of-stone January 4, 2023}
(dup. from Obsidian forum)

Issue, or lack of understanding?: I am using Obs. 1.1.9 on a Mac Pro under MacOS Ventura.

I have one shell command registered and it functions correctly, however where the alias should appear in the file context menu is a blank item:

...

I suspect that the bug only happens on macOS (not 100% certain, though). I suspect the problem is that menu title generation takes too long, and by the time the title is generated (i.e. variables parsed), the title text is set too late to the menu item, and so it doesn't appear visually in the menu on some systems.

TODO:

• If 0.18.0 doesn't fix the bug, remove this issue from CHANGELOG.md.
• Fix the bug by setting the menu item title as soon as possible. This means setting the title before {{variables}} are parsed in the title, so the menu might show unparsed {{variable}} texts. After variable parsing finishes a few milliseconds later, the menu title should be updated so that actual variable values will show instead of {{variable}} texts.
• Create a feature request for Obsidian so that Menu.addItem() would support asynchronous callback functions. This is for improving the menu item title generation later. The first version of the fix should not need this. Edit: Here: https://forum.obsidian.md/t/menu-additem-support-asynchronous-callback-functions/52870/2

[Taitava]

Commit 0b2badd did not actually fix this issue. It fixed another, similar bug (which was not in production) and so I edited the commit message (removed #314). For this reason, the commit does not exist in any branch any more.

The new commit hash, with a slightly different commit message, but same changes, is here: d881ebf

[Taitava]

So the bug is still unresolved.

[Taitava]

I was able to confirm on my friend's Mac that commit 819fa50 fixes the bug. 👍 Will release the fix in 0.18.1.