Skip to content

HTM-1660: Change login screen #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Oct 3, 2025
Merged

HTM-1660: Change login screen #1009

merged 18 commits into from
Oct 3, 2025

Conversation

steinkobben
Copy link
Contributor

@steinkobben steinkobben commented Sep 29, 2025 •
edited
Loading

HTM-1660 Powered by Pull Request Badge

  • Add icon to SSO button

Changes:

  • Larger SSO buttons
  • Move Tailormap login to expansion panel if there are SSO links

@steinkobben steinkobben self-assigned this Sep 29, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 29, 2025 •
edited
Loading

Test Results

  1 files  ±0  210 suites  ±0   8m 24s ⏱️ -4s
526 tests ±0  526 ✅ ±0  0 💤 ±0  0 ❌ ±0 
610 runs  ±0  610 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 46ec1bc. ± Comparison against base commit 8b64dfc.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Sep 30, 2025 •
edited
Loading

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
530 2 528 0
View the top 2 failed test(s) by shortest run time 
LoginFormComponent triggers login method
Stack Traces | 0.095s run time 
TestingLibraryElementError: Unable to find a label with the text of: Username

Ignored nodes: comments, script, style
<body>
  <div
    id="root1"
    ng-version="20.1.4"
  >
    <mat-spinner
      color="primary"
      diameter="20"
      mode="indeterminate"
    />
  </div>
</body>
    at Object.getElementError (.../tailormap-viewer/tailormap-viewer/node_modules/@.../dom/dist/config.js:37:19)
    at getAllByLabelText (.../tailormap-viewer/tailormap-viewer/node_modules/@.../dist/queries/label-text.js:111:38)
    at .../tailormap-viewer/tailormap-viewer/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../tailormap-viewer/tailormap-viewer/node_modules/@.../dom/dist/query-helpers.js:95:19
    at .../login/login-form/login-form.component.spec.ts:49:38
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
LoginFormComponent should render
Stack Traces | 0.25s run time 
TestingLibraryElementError: Unable to find an element with the text: Username. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
<body>
  <div
    id="root0"
    ng-version="20.1.4"
  >
    <mat-spinner
      color="primary"
      diameter="20"
      mode="indeterminate"
    />
  </div>
</body>
    at Object.getElementError (.../tailormap-viewer/tailormap-viewer/node_modules/@.../dom/dist/config.js:37:19)
    at .../tailormap-viewer/tailormap-viewer/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../tailormap-viewer/tailormap-viewer/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../tailormap-viewer/tailormap-viewer/node_modules/@.../dom/dist/query-helpers.js:95:19
    at .../login/login-form/login-form.component.spec.ts:22:19
    at processTicksAndRejections (node:internal/process/task_queues:105:5)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@steinkobben steinkobben requested a review from matthijsln October 1, 2025 14:06
@steinkobben steinkobben marked this pull request as ready for review October 1, 2025 14:07
@mprins mprins added the enhancement New feature or request label Oct 3, 2025
@mprins mprins enabled auto-merge (squash) October 3, 2025 07:11
@steinkobben steinkobben requested a review from mprins October 3, 2025 09:41
mprins
mprins approved these changes Oct 3, 2025
View reviewed changes
Copy link
Contributor

@mprins mprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested in depth, i could uplaod an image but have no other config, but lgtm

@mprins mprins merged commit e33fadb into main Oct 3, 2025
13 checks passed
@mprins mprins deleted the dev/htm-1660 branch October 3, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mprins mprins mprins approved these changes

@matthijsln matthijsln Awaiting requested review from matthijsln

Assignees

@steinkobben steinkobben

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steinkobben @mprins