Type improvements to landing.py and panel.py#960
Type improvements to landing.py and panel.py#960CyanVoxel merged 6 commits intoTagStudioDev:mainfrom
Conversation
Computerdores
left a comment
There was a problem hiding this comment.
Note: I the comments I added aren't issues with what you did, but issues with the code you touched that might as well be fixed now while the code is being changed anyways
Co-Authored-By: Jann Stute <46534683+Computerdores@users.noreply.github.com>
Computerdores
left a comment
There was a problem hiding this comment.
I am sorry if this was unclear, but what I intended to say was that both the title and the window title could be moved to the constructor.
Unless it was clear enough and you didn't do it for another reason?
I changed the code to pass the title to the constructor as you suggested. since the |
use `title` if `window_title` is `None` Co-Authored-By: Jann Stute <46534683+Computerdores@users.noreply.github.com>
|
Thank you for the changes, and @Computerdores for the reviews! |
Summary
PanelModalclass (in panel.py) and updated all references in other filesTasks Completed