feat(ui): add more default icons and file type equivalencies #882
Conversation
CyanVoxel
added
Type: QoL
Note: a lot of the zip-based code is becoming duplicated - this should be consolidated in the future.
|
I apologize for the barrage of new commits - I've updated the database icon in addition to adding a few more tweaks and additions, most notably the addition of iWork and PowerPoint thumbnail extraction. I've noticed a lot of overlap with these zip-based thumbnail formats, so I'd be interested in refactoring all of them into a single method in a future PR. |
| @classmethod | ||
| def _powerpoint_thumb(cls, filepath: Path) -> Image.Image | None: |
There was a problem hiding this comment.
I would suggest changing this and the _iwork_thumb to staticmethods since these don't actually use the class they are part of and might as well be independet methods
There was a problem hiding this comment.
There's quite a few @classmethod methods in here, with none of them (plus the regular self methods) seemingly needing to be that way. I've locally tested making the vast majority of them static methods and there doesn't seem to be a downside. Should I go ahead and do that?
| cached_path = Path( | ||
| self.lib.library_dir | ||
| / TS_FOLDER_NAME | ||
| / THUMB_CACHE_NAME |
There was a problem hiding this comment.
Why this change? Afaik the / operator only works on Paths and also returns a Path
There was a problem hiding this comment.
On paper it should be functionally the same, but Pyright gives a reportUnknownVariableType warning here since it can't deduce that the parenthesis syntax will always give a Path. I figured I could either add an ignore comment for the warning, or just explicitly call the Path constructor to provide the type hint.
Type of "cached_path" is partially unknown
Type of "cached_path" is "Unknown | Path | None"
basedpyright[reportUnknownVariableType](https://docs.basedpyright.com/v1.28.3/configuration/config-files/#reportUnknownVariableType)
|
Everything should be addressed now, though I did add some quick error handling for PowerPoint thumbs since I came across that while testing the static methods, plus some quick type hints for some of the thumb renderer dicts. I'll refrain from doing any more type hint fixing for now, since that's better off in a dedicated PR... |
|
Thank you so much for the review! |
Funfact: I had actually done all these refactors already, but then decided not to push them because I had originally wanted to include them in a PR that uncouples the image loading (only to then discover that it kept SEGFAULTing) |
github-project-automation
bot
moved this from 🍃 Pending Merge
to ✅ Done
in TagStudio Development
Summary
This PR adds various new fallback icons, file type equivalencies, and explicitly defined media types.
Tasks Completed