Skip to content

feat: add filename sorting #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 13, 2025

Conversation

Computerdores
Copy link
Collaborator

@Computerdores Computerdores commented Mar 7, 2025

Summary

Note: The failing test is due to an issue that is present on main and has gone unnoticed until now. I have added the missing assertion so it should be easy to fix in a separate PR.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@Computerdores Computerdores moved this to 🚧 In progress in TagStudio Development Mar 7, 2025
@Computerdores Computerdores added Type: Enhancement New feature or request Type: UI/UX User interface and/or user experience Priority: High An important issue requiring attention labels Mar 7, 2025
@Computerdores Computerdores marked this pull request as ready for review March 7, 2025 22:34
@Computerdores Computerdores moved this from 🚧 In progress to 🏓 Ready for Review in TagStudio Development Mar 7, 2025
@Computerdores
Copy link
Collaborator Author

this is now ready for review

@CyanVoxel CyanVoxel added Status: Blocked This issue or pull request is awaiting the outcome of another issue or pull request and removed Status: Blocked This issue or pull request is awaiting the outcome of another issue or pull request labels Mar 7, 2025
@CyanVoxel CyanVoxel moved this from 🏓 Ready for Review to 🚧 In progress in TagStudio Development Mar 10, 2025
@CyanVoxel CyanVoxel moved this from 🚧 In progress to 🏓 Ready for Review in TagStudio Development Mar 10, 2025
@CyanVoxel
Copy link
Member

I apologize for the inconvenience, #844 has now been pulled and a rebase targeting main will be required here now.
Thank you for your work on this so far, and sorry again for the disruption!

@Computerdores Computerdores moved this from 🏓 Ready for Review to 🚧 In progress in TagStudio Development Mar 10, 2025
@Computerdores Computerdores force-pushed the feat/filename_sorting branch from 620cf6c to e358594 Compare March 10, 2025 18:00
@Computerdores
Copy link
Collaborator Author

rebase is done. I have also fixed the search test by updating the search library to the latest db version. Further I have added a db migration test for the new migration

@Computerdores Computerdores moved this from 🚧 In progress to 🏓 Ready for Review in TagStudio Development Mar 10, 2025
@CyanVoxel CyanVoxel added the Status: Review Needed A review of this is needed label Mar 10, 2025
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good here, the only rough spot I've run into is that it can take some time for the new filename column to populate when opening a library (45 seconds for 200k files on an SSD for me).

It may be a good idea (in a future PR if antyhing) to reformat the SQL to SQL migration logic in a way similar to how the JSON to SQL logic checks in with the frontend first before migrating, just to allow for something like an indefinite progress bar popup notifying the user that things are still happening. Though this process also took place during the splash screen for me since I used the launch flags, so maybe there's even more than needs to be considered first.

In any case, thank you so much for your work on adding this! And thank you for updating the test files as well!

@CyanVoxel CyanVoxel removed the Status: Review Needed A review of this is needed label Mar 13, 2025
@CyanVoxel CyanVoxel moved this from 🏓 Ready for Review to 🍃 Pending Merge in TagStudio Development Mar 13, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5.2 milestone Mar 13, 2025
@CyanVoxel CyanVoxel merged commit 3183324 into TagStudioDev:main Mar 13, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from 🍃 Pending Merge to ✅ Done in TagStudio Development Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High An important issue requiring attention Type: Enhancement New feature or request Type: UI/UX User interface and/or user experience
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Sort by Filename
2 participants