Skip to content

fix: log all problems in translation test #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Computerdores
Copy link
Collaborator

Summary

Changes the structure of the translation test, without changes in tested behaviour, to log all problems that can be found instead of just the first.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@Computerdores Computerdores added Type: Enhancement New feature or request Type: Tests Tests or testing related Status: Review Needed A review of this is needed Type: Translations Modifies translation keys or translation capabilities. labels Mar 7, 2025
@Computerdores Computerdores moved this to 🏓 Ready for Review in TagStudio Development Mar 7, 2025
@Computerdores Computerdores added the Priority: Low Doesn't require immediate attention label Mar 7, 2025
@CyanVoxel CyanVoxel added the Status: Blocked This issue or pull request is awaiting the outcome of another issue or pull request label Mar 7, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5.2 milestone Mar 7, 2025
@CyanVoxel CyanVoxel removed the Status: Blocked This issue or pull request is awaiting the outcome of another issue or pull request label Mar 10, 2025
@Computerdores Computerdores force-pushed the fix/translations_test_log_all_problems branch from 1a56500 to 1229344 Compare March 10, 2025 12:26
@CyanVoxel CyanVoxel removed the Status: Review Needed A review of this is needed label Mar 11, 2025
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this with some of the older translation files containing errors, and this seems to work as intended and picks everything up!

Thank you so much for your work on this, it's be a big help!

@CyanVoxel CyanVoxel moved this from 🏓 Ready for Review to 🍃 Pending Merge in TagStudio Development Mar 11, 2025
@CyanVoxel CyanVoxel merged commit e308e8e into TagStudioDev:main Mar 11, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from 🍃 Pending Merge to ✅ Done in TagStudio Development Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Doesn't require immediate attention Type: Enhancement New feature or request Type: Tests Tests or testing related Type: Translations Modifies translation keys or translation capabilities.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants