fix: restore translate_formatted() method
#830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Bug
Collaborator
Collaborator
Computerdores
left a comment
Computerdores
left a comment
There was a problem hiding this comment.
No issues besides what was mentioned before
tagstudio/src/qt/translations.py
Outdated
| ) | ||
| return text | ||
|
|
||
| def translate_formatted(self, key: str, **kwargs) -> str: |
Collaborator
There was a problem hiding this comment.
I would suggest renaming this to formatted as outlined in the comment
Member
Author
There was a problem hiding this comment.
I was looking forward to doing this as well
| self._lang = lang | ||
| self._strings = self.__get_translation_dict(lang) | ||
|
|
||
| def __format(self, text: str, **kwargs) -> str: |
Collaborator
There was a problem hiding this comment.
I would suggest porting the improvements from #829
Collaborator
There was a problem hiding this comment.
I would change it to this (plus an import for defaultdict at the top):
def __format(self, text: str, *args, **kwargs) -> str:
try:
return text.format(*args, **kwargs)
except (KeyError, ValueError):
logger.error(
"[Translations] Error while formatting translation.",
text=text,
kwargs=kwargs,
language=self._lang,
)
params: defaultdict = defaultdict(lambda: "{missing_key}")
params.update(kwargs)
return super().format_map(params)
8 tasks
Computerdores
approved these changes
Mar 6, 2025
github-project-automation
bot
moved this from 🍃 Pending Merge
to ✅ Done
in TagStudio Development
csponge
pushed a commit
to csponge/TagStudio
that referenced
this pull request
Mar 10, 2025
…ev#830) * fix: restore `translate_formatted()` method * fix: set "Create & Add" button text * refactor: rename "translate_formatted" to "format" * translations: replace invalid format key names with "{unknown_key}"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR restores the use of the
translate_formatted()method (now refactored as justformat()) that was removed in #817 in order to catch KeyErrors raised from invalid formatting keys being added in the translation files and passed to.format()calls.Tasks Completed
Tested on:
Tested for:
Closes [Bug]: Switching translations causes error on program start #827, along with the fixed translations in Translations update from Hosted Weblate #826.