Skip to content

fix: KeyError when formatting translation #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion tagstudio/src/qt/translations.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from collections import defaultdict
from pathlib import Path

import structlog
Expand All @@ -8,6 +9,29 @@
DEFAULT_TRANSLATION = "en"


class ErrorlessFormatString(str):
__translator: "Translator"

def __new__(cls, translator: "Translator", object: object = ""):
obj = super().__new__(cls, object)
obj.__translator = translator
return obj

def format(self, *args: object, **kwargs: object) -> str:
try:
return super().format(*args, **kwargs)
except KeyError:
logger.error(
"[Translations] Error while formatting translation.",
text=self,
language=self.__translator._lang,
kwargs=kwargs,
)
params: defaultdict = defaultdict(lambda: "{missing_key}")
params.update(kwargs)
return super().format_map(params)


class Translator:
_default_strings: dict[str, str]
_strings: dict[str, str] = {}
Expand All @@ -28,7 +52,9 @@ def change_language(self, lang: str):
self._strings = self.__get_translation_dict(lang)

def __getitem__(self, key: str) -> str:
return self._strings.get(key) or self._default_strings.get(key) or f"[{key}]"
return ErrorlessFormatString(
self, self._strings.get(key) or self._default_strings.get(key) or f"[{key}]"
)


Translations = Translator()