fix(ui): revert all item_thumb "pressed" changes (Fix #732)
#742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Bug
This was referenced Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the critical issue of not being able to ctrl+deselect items in the thumbnail grid (#732) by reverting the "thumb_button.clicked -> thumb_button.pressed" changes made in #556, which caused the drag and drop issue described in #706, which was later addressed in #710, however with the side effect of causing the selection issue described in #732.
This PR knowingly comes with a regression to the click behavior prior to #555, however the time sensitivity and severity of #732 outweighs the enhancement requested in #555.