Ability to open file or file location using context menu #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
approved these changes
Apr 27, 2024
There was a problem hiding this comment.
Looks pretty good! The only real issue I have is the way the file explorer is selected and ran on Windows vs other platforms, which currently wouldn't work on Linux or macOS due to the nautilus command plus the use of os.startfile, which is a Windows-only specific command.
Normally I would request changes for the PR, but we're working on pulling in the rest of the new feature changes today in order to refactor this specific file. I'll likely open an issue for it after the refactor if you'd like to address it once the classes are broken up into separate files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to open the file or view it in the file explorer using a context menu or by clicking directly on path.
Should work with in Unix, but I didn't test it (my linux died).
Recording.2024-04-27.094010.mp4