fix(#655): search now works again #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Refactor
CyanVoxel
approved these changes
Dec 22, 2024
CyanVoxel
merged commit caf099c
into
TagStudioDev:tag-categories-feat
2 of 5 checks passed
CyanVoxel
pushed a commit
that referenced
this pull request
Jan 5, 2025
CyanVoxel
pushed a commit
that referenced
this pull request
Jan 6, 2025
CyanVoxel
added a commit
that referenced
this pull request
Jan 11, 2025
* refactor: remove TagBoxField and TagField (NOT WORKING) * refactor: remove tag field types * ci: fix mypy and ruff tests * refactor: split up preview_panel * fix: search now uses `TagEntry` (#656) * fix: move theme check inside class * refactor: reimplement file previews * refactor: modularize `file_attributes.py` * ui: show fields in preview panel known issues: - fields to not visually update after being edited until the entries are reloaded from the thumbnail grid (yes, the thumbnail grid) - add field button currently non-functional - surprise segfaults * search: remove TagEntry join * fix: remove extra `self.filter` assignment * add success return flag to `add_tags_to_entry()` * refactor: use entry IDs instead of objects and indices - fixes preview panel not updating after entry edits - fixes slow selection performance - fixes double render call * feat: add tag categories to preview panel * ui: add "is category" checkbox in tag panel * fix: tags can be compared for name sorting * fix: don't add tags to previous selections * fix: badges now properly update * ui: hide sizeGrip * ui: add blue ui color * ui: display empty selection; better multi-selection * cleanup comments; rename tsp to tag_search_panel * fix(ui): properly unset container callbacks * fix: optimize queries * fix: catch int cast exception * fix: remove unnecessary update calls * fix: restore try/except block in preview_panel * fix: correct type hints for get_tag_categories * fix: tags no longer lazy load subtags and aliases * fix: recursively include parent tag categories * chore: update copyright info * chore: remove unused code * fix: load fields for selected entry * refactor: remove `is_connected` from AddFieldModal * fix: include category tags under their own categories * fix: badges now update when last tag is removed * fix: resolve differences with main * fix: return empty set in place of `None` * ui: add field highlighting, tweak theming * refactor!: eradicate use of the term "subtag" - Removes ambiguity between the use of the term "parent tag" and "subtag" - Fixes inconstancies between the use of the term "subtag" to refer to either parent tags or child tags - Fixes duplicate and ambiguous subtags mapped relationship for the Tag model - Does NOT fix tests * fix: catch and show library load errors * tests: fix and/or remove tests * suppress db preference warnings * tests: add field container tests * tests: add tag category tests * refactor(ui): move recent libraries list to file menu * docs: update roadmap and docs for tag categories * fix: restore json migration functionality * logs: remove/update debug logs * chore: remove unused code * tests: remove tests related to `TagBoxWidget` * ui: optimize selection and badge updates * docs: update usage * fix: change typo of `tag.id` to `tag_id` Co-authored-by: Jann Stute <46534683+Computerdores@users.noreply.github.com> * fix: use term "child tags" instead of "subtags" in docstring Co-authored-by: Jann Stute <46534683+Computerdores@users.noreply.github.com> * fix: reference `child_id` instead of `parent_id` when deleting tags Co-Authored-By: Jann Stute <46534683+Computerdores@users.noreply.github.com> * add TODO comment for `update_thumbs()` optimization * fix: combine and check (most) built-in tag data from JSON Known issue: Tag colors from built-in JSON tags are not updated. This can be seen in the failing test. * refactor: rename `select_item()` to `toggle_item_selection()` * add TODO to optimize `add_tags_to_entry()` * fix: remove unnecessary joins in search * Revert "fix: remove unnecessary joins in search" This reverts commit 4c019ca. * fix: remove unnecessary joins in search * reremove unused method `get_all_child_tag_ids()` * fix: migrate user-edited tag colors for built-in tags * style: update header for contributor-created files * fix: use absolute path in "open file" context menu * chore: change paramater type hint --------- Co-authored-by: python357-1 <jb2101554@gmail.com> Co-authored-by: Jann Stute <46534683+Computerdores@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the search for #655