-
-
Notifications
You must be signed in to change notification settings - Fork 394
fix: stop sqlite db from being updated while running tests #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Only running the |
I don't know how to check if the schema is the same to do this - even the sqldiff tool didn't detect this. The reason we are doing the insert and delete is to make sure the next auto increment ID is at least 1000. This implementation allows it to skip updating the database if the next ID is at least 1000. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the issue for me on Win10 and I don't see anything wrong with the code either (no idea whether using sessionmaker
is better here, but I see nothing wrong with it)
yeah i actually just fixed that, realized there was no need for that to be there lol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this fixes the modification issues without breaking the auto-increment values 👍
This PR fixes #644 by having
make_tables
check the current autoincrement value (what the next inserted row would have as its id) on thetags
table. Previously, anINSERT
and aDELETE
were always being run when a library was opened, causing the file change counter to increaseclose #644
close #646