-
-
Notifications
You must be signed in to change notification settings - Fork 394
feat: Improve performance of Delete Missing Entries function #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This technically removes the usefulness progress indicator, but brief testing on my end had it delete ~8000 entries in less time than it took me to see if the progress indicator was properly indeterminate or not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very good! This makes the deletion process go from roughly 1-2min for 1500 unlinked entries to just under 5s!
Sorry for the delay on checking this out. This seems to break when trying to delete "too many" unlinked entries all at once:
|
Ohh, good catch |
I would suggest splitting the list into multiple lists that don't exceed the maximum number of SQL variables an then running the same code on each of those (I think that maximum number should be 32766 as can be found here) |
Fixes #617 by deleting all missing entries simultaneously instead of one at a time.