feat: Audio Playback #529
Closed
feat: Audio Playback #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add the ablity to play audio files defined in the AUDIO_TYPES list. * Add a slider to seek through an audio file. * Add play/pause and mute/unmute buttons for audio files. Refs: #450
CyanVoxel
added
Type: Enhancement
3 tasks
|
Any reason why this was closed? |
Seems like they didn't realise deleting their fork would close the commit. @csponge |
|
Ah, that's my bad. Didn't realize that would happen. Would it be possible to fix this by recreating the branch? If not, maybe I can open a new PR? Sorry for the confusion. |
I believe a new PR would be needed if the original fork and/or branch is deleted, unless there's a way to undo that in a way that GitHub is pleased with that I'm unaware of |
3 tasks
|
Okay, I'll work on making a new PR. Again, sorry for the confusion. |
csponge
added a commit
to csponge/TagStudio
that referenced
this pull request
Nov 6, 2024
Add the ability to play audio files. Add a slider to seek through an audio file. Add play/pause and mute/unmute buttons for audio files. Note: This is a continuation of a mistakenly closed PR: Ref: TagStudioDev#529 While redoing the changes, I made a couple of improvements. When the end of the track is reached, the pause button will swap to the play button and allow the track to be replayed. Here is the original feature request: Ref: TagStudioDev#450
Merged
CyanVoxel
pushed a commit
that referenced
this pull request
Nov 29, 2024
* feat: Audio Playback Add the ability to play audio files. Add a slider to seek through an audio file. Add play/pause and mute/unmute buttons for audio files. Note: This is a continuation of a mistakenly closed PR: Ref: #529 While redoing the changes, I made a couple of improvements. When the end of the track is reached, the pause button will swap to the play button and allow the track to be replayed. Here is the original feature request: Ref: #450 * fix: prevent autoplay on new track when paused * refactor: Add MediaPlayer base class. Added a MediaPlayer base class per some suggestions in the PR comments. Hopefully this reduces duplicate code between the audio/video player in the future. * refactor: add controls to base MediaPlayer class Move media controls from the AudioPlayer widget to the MediaPlayer base class. This removes the need for a separate AudioPlayer class, and allows the video player to reuse the media controls. * fix: position_label update with slider Update the position_label when the slider is moving. * fix: replace platform dependent time formatting Replace the use of `-` in the time format since this is not availabile on all platforms. Update initial `position_label` value to '0:00'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to play audio files. Additionally, it adds a few new UI elements for interacting with audio. Below is a list of the newly added elements:
NOTE: There are a few bugs to work out, but I think they would be better suited for new issues because they affect more than just the audio player.
Refs: #450