Skip to content

Sidecar macro fixes #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Computerdores
Copy link
Collaborator

This Pull Request addresses 3 Bugs I found while using the gallery_dl-sidecar importing feature:

  1. Running macros on files that aren't in a subdirectory was broken (see 1d45701).
  2. For filename.jpg get_gdl_sidecar would try to load filename.json instead of filename.jpg.json, which is the default filename format used by gallery_dl (see a0562a8).
  3. add_generic_data_to_entry would create a second Content Tags Field if the existing Content Tags field was the first field, because an if-statement used > instead of >= (see fbd2244).

I didn't create an Issue first because I had already fixed these issues in order to use the autofill macro to import gdl sidecar files.

@CyanVoxel CyanVoxel added Type: Enhancement New feature or request TagStudio: Library Relating to the TagStudio library system Priority: Low Doesn't require immediate attention Status: Review Needed A review of this is needed labels Aug 27, 2024
@CyanVoxel CyanVoxel self-assigned this Aug 31, 2024
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this up! I know this is an unfinished + undocumented feature, but it seems to be working back up to its old standard now. After the .lower() comment is resolved this should be good to go!

@CyanVoxel CyanVoxel added Status: Changes Requested Changes are quested to this and removed Status: Review Needed A review of this is needed labels Aug 31, 2024
Co-authored-by: Travis Abendshien <46939827+CyanVoxel@users.noreply.github.com>
@CyanVoxel CyanVoxel added Status: Mergeable The code is ready to be merged and removed Status: Changes Requested Changes are quested to this labels Aug 31, 2024
@CyanVoxel CyanVoxel merged commit 85d62e6 into TagStudioDev:Alpha-v9.4 Sep 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Doesn't require immediate attention Status: Mergeable The code is ready to be merged TagStudio: Library Relating to the TagStudio library system Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants