Fix ts_qt empty file bug, show more file previews, and rename "Show file in explorer" to vary based on OS #358
Conversation
|
This PR is trying to do a lot of separate things at once. I would suggest breaking it up into separate PRs for each issue, and opening any bug reports for bugs you're trying to address that don't already have open issues. That way myself and others can attempt to replicate and verify the issues first. In addition, the |
Oh okay. So should I close this and reopen multiple pull requests? |
That would be preferred 👍 |
Okay, closing now. |
Previously, when you pressed the forward arrow and there wasn't anything to go forward with, it would raise this error:
TypeError: object of type 'bool' has no len() Calling NavForward with Content:False, Index:0, PageCount:0 Traceback (most recent call last): File "/Users/maxpersonal/Downloads/TagStudio/tagstudio/src/qt/ts_qt.py", line 1008, in nav_forward self.update_thumbs() File "/Users/maxpersonal/Downloads/TagStudio/tagstudio/src/qt/ts_qt.py", line 1218, in update_thumbs if i < len(self.nav_frames[self.cur_frame_idx].contents):This has been fixed.
Second, I made it so Python, C, C++, C#, and Yaml files are rendered as plain text.
Lastly, I made it so it either says reveal in Finder or show in explorer based on the operating system. I don't know what it usually says on Linux, as I've never used it, so I made it stay the same, but somebody else could change this later.