-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved handling of animated images #357
base: Alpha-v9.4
Are you sure you want to change the base?
Conversation
2c4e35d
to
2a15886
Compare
i added some code to test converting into animated webp before showing the image but it's sometimes causing crashing and i have no idea why, when it works for a small amount of time it seems to work. |
|
Wanted to chime in here with the state of this PR and other relevant developments around the project. #344 was at a sticking point regarding licenses, but is probably going to move forward with pillow-jpegxl-plugin assuming it functions correctly (I need to get my hands on some .jxl files). In the meantime, I've unknowingly implemented some of changes here in #409 - mostly the animated image media type category and some code for loading GIFs into memory rather than streaming them from disk. I would also suggest rebasing this to |
ce2dc6c
to
3fe7d4d
Compare
@CyanVoxel i manually merged the work from the older version of this branch on to |
Are no tests affected by this PR after the gif changes? And is there a way to add missing tests? |
@eivl are there any tests for animated image handling?
probably |
I've changed the handling of animated images to include support for more types of animated images.
PR features:
this PR also includes the changes from #344 so feel free to close that one if you prefer this one, though sadly that plugin doesn't seem to support decoding animated jxls
this also closes #333