Skip to content

feat: drag-n-drop into other applications #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Technoguyfication
Copy link

Dead simple drag-n-drop implementation because I was surprised this doesn't exist yet. Example here:

Discord_A8bc5cWD9E

This can definitely be improved upon, but this was a quick and easy addition. Tested on Windows 11. Will test on Linux Mint (Cinnamon) shortly and I'll update the PR with my results.

closes #75

@CyanVoxel
Copy link
Member

This looks great, however pull request #153 is also adding this same functionality

@CyanVoxel CyanVoxel added Type: Duplicate This issue or pull request already exists Type: Enhancement New feature or request labels Jun 13, 2024
@Technoguyfication
Copy link
Author

Technoguyfication commented Jun 13, 2024

This looks great, however pull request #153 is also adding this same functionality

Yeah, I saw that after making my PR haha. It seemed to be a little bit stalled so I figured this one could be merged in the event that the other one needed some major changes. It looks pretty solid though, feel free to close this one since it's made redundant by #153

@CyanVoxel
Copy link
Member

Yeah, I saw that after making my PR haha. It seemed to be a little bit stalled so I figured this one could be merged in the event that the other one needed some major changes. It looks pretty solid though, feel free to close this one since it's made redundant by #153

Yeah since it had the ability to import files via dropping as well it's taken me longer to get to get around to signing off on it compared to other PRs and fixes haha. If this had come before that one, then this would've been such a quick pull comparatively. Now that 9.3.1 is out though I'll be able to get some of these backlogged feature and refactor PRs merged.

I'll likely end up closing this one assuming the other is ready to be pulled, but still thank you for your work on this!

@CyanVoxel CyanVoxel closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Duplicate This issue or pull request already exists Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[suggestion] drag and drop outside the window
2 participants