Add "Clear Selection" button #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Enhancement
CyanVoxel
requested changes
Jun 7, 2024
There was a problem hiding this comment.
Looks pretty good! The ability to clear the grid selection is a much-needed QoL feature. My only real gripe is the key command choice, which I've suggested a change for.
Besides that, it would be nice if both this and the "Select All" options were in their own "Select" menu, however the menu bar is in need of it's own reorganizing and cleanup anyway so I'd say that's out of the scope of this PR.
CyanVoxel
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply lets you clear the current entry selection through the Edit -> Clear Selection button, or by pressing Ctrl+D. A minor feature I think would be very convenient.
I am quite unfamiliar with both Python and Qt, so please let me know if there is anything I should change or improve.