Skip to content

Update to pyside6 version 6.7.1 #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 16, 2024

Conversation

Thesacraft
Copy link
Collaborator

@Thesacraft Thesacraft commented May 26, 2024

I updatet the project to use pyside6 6.7.1 / Qt 6.7.1.
I had to change the way signals where disconnected because the RuntimeError was replaced by a RuntimeWarning which is not catched by a try-except block. I fixed one bug that was introduced but i did not find more so feel free to test for bugs.
I am open to changes :)

@CyanVoxel CyanVoxel added the Type: Refactor Code that needs to be restructured or cleaned up label May 29, 2024
@yedpodtrzitko
Copy link
Contributor

please remove also this line pinning PySide version when running mypy in CI, thanks. It was added there as the types in Pyside 6.6.3 are broken.

pip install PySide6==6.6.2

@CyanVoxel CyanVoxel added this to the Alpha 9.3 milestone Jun 7, 2024
@Thesacraft
Copy link
Collaborator Author

I don't know why the PySide App Test Error occurs here because in my main branch of Tagstudio(which is the same as the official main branch) it also occurs. The only idea i have is that a new numpy version is beeing used now and it fails there but i don't really know.

@Thesacraft
Copy link
Collaborator Author

I just looked into it and the main branch here passed with this following version:
numpy-1.26.4-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (61 kB)
and mine uses:
numpy-2.0.0-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (60 kB)

@Thesacraft
Copy link
Collaborator Author

Thesacraft commented Jun 16, 2024

I fixed it but is this ok in one pr or should i remove it from here and make another pr for that @CyanVoxel ?

@CyanVoxel
Copy link
Member

I fixed it but is this ok in one pr or should i remove it from here and make another pr for that @CyanVoxel ?

Yeah it's all good in this one

@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Priority: Critical An issue that requires immediate attention labels Jun 16, 2024
@CyanVoxel
Copy link
Member

Things seem to be working at a glance on my machine with the new PySide and numpy versions. I'm not exactly sure how the numpy issue has materialized but it's suddenly causing previously passed runs to fail everywhere.

My only immediate suggestion for this one would probably be to rename CustomQPushButton to something a bit more descriptive, maybe QPushButtonWrapper? Eh, it's hard to think of something good for it though...

@Thesacraft
Copy link
Collaborator Author

Thesacraft commented Jun 16, 2024

Things seem to be working at a glance on my machine with the new PySide and numpy versions. I'm not exactly sure how the numpy issue has materialized but it's suddenly causing previously passed runs to fail everywhere.

This is actually because a new numpy version (numpy 2.0) was released about 9h ago. Rawpy was built on the 1.x version of numpy and numpy 2.0 isn't supported. They seem to not have pinned the numpy version that is installed when installing rawpy. So i just pinned the numpy version to 1.26.

also renamed custom_qbutton.py to qbutton_wrapper.py
@CyanVoxel CyanVoxel merged commit b3c01e1 into TagStudioDev:main Jun 16, 2024
4 checks passed
@Thesacraft Thesacraft deleted the blank-background-bug branch June 17, 2024 00:05
@Thesacraft Thesacraft mentioned this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Critical An issue that requires immediate attention Type: Bug Something isn't working as intended Type: Refactor Code that needs to be restructured or cleaned up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants