-
-
Notifications
You must be signed in to change notification settings - Fork 394
Update to pyside6 version 6.7.1 #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to pyside6 version 6.7.1 #223
Conversation
please remove also this line pinning PySide version when running mypy in CI, thanks. It was added there as the types in Pyside 6.6.3 are broken. TagStudio/.github/workflows/mypy.yaml Line 23 in 868b553
|
I don't know why the PySide App Test Error occurs here because in my main branch of Tagstudio(which is the same as the official main branch) it also occurs. The only idea i have is that a new numpy version is beeing used now and it fails there but i don't really know. |
I just looked into it and the main branch here passed with this following version: |
I fixed it but is this ok in one pr or should i remove it from here and make another pr for that @CyanVoxel ? |
Yeah it's all good in this one |
Things seem to be working at a glance on my machine with the new PySide and numpy versions. I'm not exactly sure how the numpy issue has materialized but it's suddenly causing previously passed runs to fail everywhere. My only immediate suggestion for this one would probably be to rename |
This is actually because a new numpy version (numpy 2.0) was released about 9h ago. Rawpy was built on the 1.x version of numpy and numpy 2.0 isn't supported. They seem to not have pinned the numpy version that is installed when installing rawpy. So i just pinned the numpy version to 1.26. |
also renamed custom_qbutton.py to qbutton_wrapper.py
I updatet the project to use pyside6 6.7.1 / Qt 6.7.1.
I had to change the way signals where disconnected because the RuntimeError was replaced by a RuntimeWarning which is not catched by a try-except block. I fixed one bug that was introduced but i did not find more so feel free to test for bugs.
I am open to changes :)