Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug 213 #220

Closed
wants to merge 2 commits into from
Closed

Fix bug 213 #220

wants to merge 2 commits into from

Conversation

bigjohn98pl
Copy link

@bigjohn98pl bigjohn98pl commented May 24, 2024

I added "container.set_inner_widget(inner_container)" in the exception to fix #213
I don't know if this method is temporary or not, so I don't changed anything, but I think this need some rework. The default value shoud be the dates form the file metadata.

In library.py I see that there is a add_generic_data_to_entry() for this, but the add_field_to_entry() just set my date to ''

                      "removal in a future version. Use timezone-aware "
                      "objects to represent datetimes in UTC: "
                      "datetime.datetime.now(datetime.UTC).
@CyanVoxel
Copy link
Member

I apologize for the late comment on this.

The underlying issue of #213 is that the date fields aren't completely implemented yet, with the biggest missing piece being a UI for the user to edit them with. In reality this really shouldn't even be allowed to show as an option for the user to add, same with Collations. #213 is also encountering separate known issues stemming from #92.

So really there are two things going on here: Date Fields aren't finished yet, and it looks like there's a desire/expectation to see the modified and created dates of files.

The first issue can be solved by either removing the ability to let users add date fields altogether, or by fully implementing the date field type complete with a UI and default values.

The second issue can be solved by adding the file creation and modification dates to the file metadata section above the fields panel. This is data that's inherit to the file, while Date Fields would be intended to be populated by the user's data. This is a change I'm already working on separately.
image
Would the file/modification dates displayed like this be suitable for what you have in mind?

@bigjohn98pl
Copy link
Author

Yes, I think this is the best approach. I like to use the date of files to get what I want. It will be nice if there will be a feature that create tags bases on date. This can be similar to the tags that can be created based on the folder. With the information about date we can also manually add a date tag to a picture, or to a group of folders.

@bigjohn98pl
Copy link
Author

So if the Date Fields aren't finished yet then this merge is meaningless .

@bigjohn98pl bigjohn98pl closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Implement date field type
2 participants