Skip to content

feat: add select all hotkey #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2024

Conversation

yedpodtrzitko
Copy link
Contributor

Screenshot 2024-05-24 at 11 54 35

@CyanVoxel CyanVoxel added Type: Enhancement New feature or request Type: QoL A quality of life (QoL) enhancement or suggestion labels May 24, 2024
@@ -692,6 +705,10 @@ def add_tag_action_callback(self):
# panel.tag_updated.connect(lambda tag: self.lib.update_tag(tag))
self.modal.show()

def select_all_action_callback(self):
for item in self.item_thumbs:
item.thumb_button.set_selected(True)
Copy link
Contributor

@Creepler13 Creepler13 May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to add the entrys to the selected list since the thumb button function is only visual

Suggested change
item.thumb_button.set_selected(True)
if ((item.mode, item.item_id)) not in self.selected:
self.selected.append((item.mode, item.item_id))
item.thumb_button.set_selected(True)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, thanks

@CyanVoxel CyanVoxel merged commit 2e86784 into TagStudioDev:main May 26, 2024
3 checks passed
@yedpodtrzitko yedpodtrzitko deleted the yed/select-all branch November 18, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request Type: QoL A quality of life (QoL) enhancement or suggestion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants