fix: apply unwrap where necessary#1113
Merged
CyanVoxel merged 4 commits intoTagStudioDev:mainfrom Sep 10, 2025
Merged
Conversation
CyanVoxel
added
the
Type: Refactor
Collaborator
Author
|
tests pass for me locally unfortunately. From what I can see in the logs here, the error is not in my PR per sé, it was just not noticed before because the unwrap was missing |
Member
I have the same tests failing for me locally (macOS) |
Computerdores
force-pushed
the
fix/missing-unwrap
branch
3 times, most recently
from
abe345f to
f115edd
Compare
Collaborator
Author
|
since this is only meant to be a refactor I have reverted the small changes that caused the tests to fail. Determining whether those are bugs or not will be left for a future PR |
Computerdores
moved this from 🚧 In progress
to 🏓 Ready for Review
in TagStudio Development
CyanVoxel
reviewed
Sep 9, 2025
CyanVoxel
approved these changes
Sep 10, 2025
Member
CyanVoxel
left a comment
CyanVoxel
left a comment
There was a problem hiding this comment.
Thank you for your work on this!
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in TagStudio Development
TrigamDev
added
Type: Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Progress on #1061.
Applies
unwrapin bunch of places where it was necessary. Also contains some other small things I fixed when I came across them.Tasks Completed