Conversation
CyanVoxel
added
Priority: Medium
Computerdores
approved these changes
Sep 3, 2025
Collaborator
Computerdores
left a comment
Computerdores
left a comment
There was a problem hiding this comment.
don't have time to test atm, but handling the special cases first certainly seems like a much better idea ^^
CyanVoxel
added
Status: Mergeable
github-project-automation
bot
moved this from 🍃 Pending Merge
to ✅ Done
in TagStudio Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #1091, which was caused by MIME types on the tested Linux systems to assume that
.vtffiles have the "Image" MIME type and therefore were sent to the standard image renderer rather than the bespoke VTF renderer. I've chosen to reorder the ""switch"" statement to put pseudo image types before the standard image types in order to retain the functionality of the MIME fallback while also prioritizing these specific formats.While I did not run any specific performance measurement tests, I don't believe this will make an impact since each of these checks should be O(1) since they're just set membership checks - I'd love a second opinion on this though.
Tasks Completed