feat: auto mnemonics #1082
Merged
feat: auto mnemonics #1082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Computerdores
force-pushed
the
feat/auto-mnemonics
branch
from
006bc6a to
b7be953
Compare
CyanVoxel
added
Type: Enhancement
CyanVoxel
approved these changes
Sep 1, 2025
Member
CyanVoxel
left a comment
CyanVoxel
left a comment
There was a problem hiding this comment.
Looks good on Fedora 42 KDE and doesn't intrude on macOS 15 👍
Might be good to move this to a separate file rather than keep it in the main_window.py one, but like you said that can be for a future PR.
| logger = structlog.get_logger(__name__) | ||
|
|
||
|
|
||
| def remove_accelerator_marker(label: str) -> str: |
Member
There was a problem hiding this comment.
Just a note, not requiring a change here: There's some similar functionality in change_language() of translations.py that's currently only targeting macOS
Collaborator
Author
There was a problem hiding this comment.
give me a sec to fix that
Collaborator
Author
There was a problem hiding this comment.
nvm, separate pr in a sec ^^
github-project-automation
bot
moved this from 🍃 Pending Merge
to ✅ Done
in TagStudio Development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reimplement KDE's system for autogenerating mnemonics1 which also incorporates
&markings when present, but doesn't require them to be present.Currently only works for the drop downs but could probably be adopted for the menu bar as well.
Example - File menu with all
&removed from translations:Possible Future PRs:
&from translations where now unnecessaryTasks Completed
Footnotes
See Wiki, Headerfile and Source Code ↩