refactor: unwrap instead of assert not None #1068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Computerdores
added
Type: Refactor
CyanVoxel
reviewed
Aug 28, 2025
Member
CyanVoxel
left a comment
CyanVoxel
left a comment
There was a problem hiding this comment.
Great addition! Approved when comments are addressed 👍
Collaborator
Author
|
should all be addressed |
CyanVoxel
added
Status: Mergeable
Computerdores
moved this from 🏓 Ready for Review
to 🍃 Pending Merge
in TagStudio Development
CyanVoxel
approved these changes
Aug 28, 2025
Member
CyanVoxel
left a comment
CyanVoxel
left a comment
There was a problem hiding this comment.
Thank you for your work on this!
github-project-automation
bot
moved this from 🍃 Pending Merge
to ✅ Done
in TagStudio Development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed on discord, introduces an
unwrapmethod which accepts an argument of typeT | Noneand returnsTor throws an exceptions if the argument isNone.Tasks Completed