Merged
Conversation
Contributor
Author
|
One caveat. Due to the way logging and argument parsing is set up, some logging info is printed just before the version is displayed. Hiding those logs specifically when So the output of running |
Member
|
The quirks with the logging executing before the arguments are parsed is due to something firing off the moment it is imported, and something I am addressing now after pulling this PR locally and testing. In terms of what you've done here, this is all good and mergeable. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds version arguments (
-vand--version) to TagStudio's main entrypoint.Version information is formatted as follows:
TagStudio v{VERSION} {VERSION_BRANCH}Examples:
Seeing as this is only a small change, I've opted to open this PR without prior discussion.
Tasks Completed