fix(search): pass current BrowsingState to from_tag_id()
#1038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Bug
Co-authored-by: Jann Stute <46534683+Computerdores@users.noreply.github.com>
Member
Author
|
@Computerdores Thank you for the review! Changes implemented 👍 |
github-project-automation
bot
moved this from 🏓 Ready for Review
to ✅ Done
in TagStudio Development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
BrowsingStateobjects created via thefrom_tag_id()not respecting the current sorting options by allowing the method to receive an optionalBrowsingStateobject to use the current sorting information from and passing the currentBrowsingStatein all instances of this method call. Fixes #1031.Tasks Completed