Skip to content

fix: don't fail when posix env var is not present #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CyanVoxel merged 2 commits into from
Aug 5, 2025
Merged

fix: don't fail when posix env var is not present #1018

CyanVoxel merged 2 commits into from
Aug 5, 2025

Conversation

@Computerdores
Copy link
Collaborator

@Computerdores Computerdores commented Aug 5, 2025

Summary

Closes #1017.

MacOS testing required.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@Computerdores Computerdores moved this to 🏓 Ready for Review in TagStudio Development Aug 5, 2025
@Computerdores Computerdores added Type: Bug Something isn't working as intended Priority: High An important issue requiring attention System: Windows For Microsoft Windows System: macOS For the macOS operating system labels Aug 5, 2025
@Computerdores Computerdores changed the title fix: don't set MacOS specific values when not on MacOS fix: don't fail when posix env var is not present Aug 5, 2025
@CyanVoxel CyanVoxel moved this from 🏓 Ready for Review to 👀 In review in TagStudio Development Aug 5, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5.3 milestone Aug 5, 2025
CyanVoxel
CyanVoxel approved these changes Aug 5, 2025
View reviewed changes
Copy link
Member

@CyanVoxel CyanVoxel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I don't use FFmpeg via Nix on macOS, I can verify that the user variable still successfully works on macOS 15:
['', '/opt/homebrew/bin/', '/usr/local/bin/', '/etc/profiles/per-user/cyanvoxel/bin']
(also tested to work on Linux just to make sure)

@CyanVoxel CyanVoxel merged commit fa0b82c into TagStudioDev:main Aug 5, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in TagStudio Development Aug 5, 2025
@Computerdores Computerdores deleted the 1017-user-environment-variable-not-present-on-win10 branch August 28, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyanVoxel CyanVoxel CyanVoxel approved these changes

Assignees

No one assigned

Labels

Priority: High An important issue requiring attention System: macOS For the macOS operating system System: Windows For Microsoft Windows Type: Bug Something isn't working as intended

Projects

TagStudio Development
Status: ✅ Done

Milestone

Alpha v9.5.3

Development

Successfully merging this pull request may close these issues.

[Bug]: USER Environment Variable not present on Win10

2 participants

@Computerdores @CyanVoxel