Skip to content

fix(ui): show correct thumb labels #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CyanVoxel merged 2 commits into from
Aug 7, 2025
Merged

fix(ui): show correct thumb labels #1010

CyanVoxel merged 2 commits into from
Aug 7, 2025

Conversation

@CyanVoxel
Copy link
Member

@CyanVoxel CyanVoxel commented Aug 4, 2025

Summary

This PR implements the following fixes and changes:

  • Fixes duration labels appearing on incorrect thumbnails
  • Fixes small empty file extension labels from appearing on loading thumbnails
  • Fixes filenames and extensions from appearing on loading thumbnails from previously queued renders that don't make the timestamp cutoff
  • Refactors the ItemThumb timestamp cutoff logic to make timestamps optional for any method that uses them

Fixes #1009, Fixes #965

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@CyanVoxel CyanVoxel added this to the Alpha v9.5.3 milestone Aug 4, 2025
@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Type: UI/UX User interface and/or user experience Priority: Medium An issue that shouldn't be be saved for last Status: Review Needed A review of this is needed labels Aug 4, 2025
@CyanVoxel CyanVoxel moved this to 🏓 Ready for Review in TagStudio Development Aug 4, 2025
@CyanVoxel CyanVoxel changed the title fix(ui): show current thumb labels fix(ui): show correct thumb labels Aug 4, 2025
@CyanVoxel CyanVoxel removed the Status: Review Needed A review of this is needed label Aug 7, 2025
@CyanVoxel CyanVoxel merged commit 78e29a9 into main Aug 7, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from 🏓 Ready for Review to ✅ Done in TagStudio Development Aug 7, 2025
@CyanVoxel CyanVoxel deleted the fix-1009 branch August 7, 2025 19:33
@CyanVoxel CyanVoxel mentioned this pull request Sep 12, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Priority: Medium An issue that shouldn't be be saved for last Type: Bug Something isn't working as intended Type: UI/UX User interface and/or user experience

Projects

TagStudio Development
Status: ✅ Done

Milestone

Alpha v9.5.3

Development

Successfully merging this pull request may close these issues.

[Bug]: Persistant Video Duration Labels [Bug]: UI displays incorrect filename when switching pages

2 participants

@CyanVoxel