Skip to content

[Bug]: App freezes after one image switch due to open_explorer_action signal connection #831

Open
@albinwwoxnerud

Description

@albinwwoxnerud

Checklist

  • I am using an up-to-date version.
  • I have read the documentation.
  • I have searched existing issues.

TagStudio Version

9.5.0-pre4

Operating System & Version

macOS, 15.3.1, 24D70

Description

When running the app directly with Python, I can open one image and switch to another once. After that, the app locks up and doesn’t allow any further interaction except favoriting via the UI star element.

Issue:

The issue is in tagstudio/src/qt/widgets/preview/preview_thumb.py, specifically in update_preview. The line that causes the lockup:

self.open_explorer_action.triggered.connect(self.opener.open_explorer)

It looks like QAction.triggered emits a boolean, which doesn’t match the expected signature of open_explorer, leading to the UI freezing.

Fix:

Changing the connection to use a lambda prevents the issue:

self.open_explorer_action.triggered.connect(lambda checked=False: self.opener.open_explorer())

This made switching work as expected for me.

I have a PR ready if this is confirmed to be a general issue and not something specific to my setup.

Expected Behavior

It should allow switching between images without restrictions.

Steps to Reproduce

  1. Open TagStudio
  2. Open a folder of JPEGs
  3. Open one image
  4. Switch to another image
  5. Application freezes

Logs

No logs due to freeze

Metadata

Metadata

Assignees

No one assigned

    Labels

    System: macOSFor the macOS operating systemType: BugSomething isn't working as intended

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions