[Bug]: TagStudio encounters error when searching for tag containing a colon

[SkeleyM]

Checklist

• I am using an up-to-date version.
• I have read the documentation.
• I have searched existing issues.

TagStudio Version

Alpha 9.5.0 (Pre-Release 1)

Operating System & Version

Windows 10 22H2

Description

Creating this on behalf of .3dz on discord

Expected Behavior

Searching for a tag containing a ':' should search accordingly

Steps to Reproduce

1. create a tag that contains a colon
2. search for the tag in the search bar, including the colon

Logs

No response

[SkeleyM]

i understand that the colon is a reserved character and can be overcame by surrounding the query in quotations but I think that could be inconvenient if a majority of tags contain a colon i.e. for categorizing common properties

[CyanVoxel]

Thank you for the report - I know I would definitely prefer a solution to not involve restricting tag names or requiring the user to escape their colons. This should be straightforward to ignore detected ConstraintTypes that don't actually exist, but it gets trickier if the tag name actually has a valid constraint type in its name. It might be work solving this issue in two parts, the first addressing false ConstraintTypes and the other addressing true tag name collision with the search syntax, after some more discussion on how the later will play out.

ConstraightType collision would also be solved with a search bar UI rework (one that was originally planned for 9.5 but was pushed) which would see tags and constraints be "autocompleted" into sub-objects inside the searchbar, so it wouldn't be purely text-based anymore. This would not be a quick feature though, and isn't something I'm immediately planning to add for the full 9.5 release.

[SkeleyM]

i can confirm ignoring detected constraint types does solve this pretty well as i had already done it.

name collisions is a trickier issue though, so im not sure if i should create a pull request without handling it. what do you think, should i submit this quick fix now? or wait until the name collision issue has been discussed some more

[CyanVoxel]

name collisions is a trickier issue though, so im not sure if i should create a pull request without handling it. what do you think, should i submit this quick fix now? or wait until the name collision issue has been discussed some more

I think for now just submit the quick fix, and we can have more time to come up with a good solution for the collision

[SkeleyM]

took a while as i had found a bug which didnt work for tags which had text after a colon (stupid i know) but all seems to work now.
ill submit the fix in a sec