Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat ScrollState Improvements & Chat Bug Fixes #7

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Chat ScrollState Improvements & Chat Bug Fixes #7

merged 3 commits into from
Jun 26, 2024

Conversation

Taewan-P
Copy link
Owner

  • Scroll to the bottom when question is asked or answer is done loading.
    • However, scroll sticking to the bottom when answer is generating is not implemented.
  • Sync scroll states (When answer is generated / answer is generating)
    • Previously, this did not sync because ScrollState is Initialized again when idle mode is switched (see 909ee7d)
  • Fixed critical error about message saving & orders
    • When regenerating answers, the message id was not synced with the saved data in the database.
    • Also there were cases when message id is saved as duplicate (This will just overwrite it and make groupedMessages weird)
    • Timestamp was not updating correctly, making another bug

@Taewan-P
Fix saved message order due to duplicate message ids
6d63e26 
This fixed weird looking message structures as well
@Taewan-P
Sync scroll state of opponent bubbles when answer is generating
909ee7d 
Previously, we just used `rememberScrollState()` so after the answer is generated completely, another ScrollState would replace the older one, making it bad UX.
@Taewan-P
Scroll to the bottom when question is asked or answer is done loading
c642dfa
@Taewan-P Taewan-P added bug Something isn't working enhancement New feature or request labels Jun 26, 2024
@Taewan-P Taewan-P self-assigned this Jun 26, 2024
@github-actions GitHub Actions
Copy link

Build complete! Here's the debug APK: https://github.com/Taewan-P/gpt_mobile/actions/runs/9682394231/artifacts/1640972096

@Taewan-P Taewan-P merged commit 8769971 into main Jun 26, 2024
3 checks passed
@Taewan-P Taewan-P deleted the feat/chat-scroll-state branch June 26, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Taewan-P Taewan-P

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Taewan-P