chore: remarks DK

.release-please-manifest.json

@@ -8,7 +8,7 @@
   "co-circom/co-plonk": "0.4.0",
   "co-noir/co-acvm": "0.3.0",
   "co-noir/co-builder": "0.1.0",
-  "co-noir/co-brillig": "0.1.0",
+  "co-noir/co-brillig": "0.0.1",
   "co-noir/co-noir": "0.3.0",
   "co-noir/co-ultrahonk": "0.2.0",
   "co-noir/ultrahonk": "0.2.0",

Cargo.toml

@@ -46,7 +46,6 @@ bytemuck = { version = "1.15", features = ["derive"] }
 byteorder = "1.5.0"
 bytes = "1.5.0"
 clap = { version = "4.4.8", features = ["derive"] }
-co-brillig = { version = "0.1.0", path = "co-noir/co-brillig" }
 color-eyre = "0.6.3"
 criterion = { version = "0.5", features = ["async_tokio"] }
 eyre = "0.6"

co-noir/co-acvm/Cargo.toml

@@ -14,7 +14,7 @@ acir.workspace = true
 acvm.workspace = true
 ark-bn254.workspace = true
 ark-ff.workspace = true
-co-brillig.workspace = true
+co-brillig= { version = "0.1.0", path = "../co-brillig" }
 eyre.workspace = true
 intmap.workspace = true
 itertools.workspace = true

co-noir/co-brillig/src/brillig_vm.rs

@@ -53,9 +53,8 @@ where
     }
 
     fn run_inner(&mut self, id: &BrilligFunctionId) -> eyre::Result<CoBrilligResult> {
-        // TODO remove clone
-        let opcodes = self.unconstrained_functions[id.as_usize()].bytecode.clone();
-        loop {
+        let opcodes = std::mem::take(&mut self.unconstrained_functions[id.as_usize()].bytecode);
+        let result = loop {
             let opcode = &opcodes[self.ip];
             tracing::debug!("running opcode: {:?}", opcode);
             match opcode {
@@ -139,10 +138,13 @@ where
                 BrilligOpcode::BlackBox(blackbox_op) => self.handle_blackbox(*blackbox_op)?,
                 BrilligOpcode::Trap { revert_data: _ } => todo!(),
                 BrilligOpcode::Stop { return_data } => {
-                    return self.handle_stop(*return_data);
+                    break self.handle_stop(*return_data);
                 }
             }
-        }
+        };
+        // move the opcodes back in
+        self.unconstrained_functions[id.as_usize()].bytecode = opcodes;
+        result
     }
 
     /// Creates a new instance of the coBrillig-VM from the provided

co-noir/co-brillig/src/memory.rs

@@ -3,12 +3,6 @@ use brillig::{IntegerBitSize, MemoryAddress};
 
 use crate::mpc::BrilligDriver;
 
-/**
-*  Copied form https://github.com/noir-lang/noir/blob/68c32b4ffd9b069fe4b119327dbf4018c17ab9d4/acvm-repo/brillig_vm/src/memory.rs
-*
-*  We cannot use the implementation because it is bound to [AcirField]
-**/
-
 pub(super) struct Memory<T, F>
 where
     T: BrilligDriver<F>,