fix(postgres): support routine introspection on PostgreSQL < 11#377
Open
earmellin wants to merge 2 commits into
Open
fix(postgres): support routine introspection on PostgreSQL < 11#377earmellin wants to merge 2 commits into
earmellin wants to merge 2 commits into
Conversation
pg_proc.prokind was added in PG 11, replacing proisagg/proiswindow. Referencing it fails with SQLSTATE 42703 on 9.x and 10. get_routines now picks a version-appropriate query based on server_version_num. Tested against PostgreSQL 9.6. Fixes TabularisDB#375
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Reviewed by kimi-k2.6 · Input: 108.2K · Output: 5.5K · Cached: 139.7K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pg_proc.prokind was added in PG 11, replacing proisagg/proiswindow.
Referencing it fails with SQLSTATE 42703 on 9.x and 10. get_routines now
picks a version-appropriate query based on server_version_num.
Tested against PostgreSQL 9.6.
Fixes #375