Repository navigation
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The change switches Files Reviewed (1 file)
Reviewed by claude-sonnet-5.5 · Input: 252 · Output: 1.4K · Cached: 152.5K Review guidance: REVIEW.md from base branch |
This was referenced Oct 17, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pnpm run typecheck(the CI "Typecheck" step) runstsc --noEmit. The roottsconfig.jsonhas"files": []and only referencestsconfig.app.jsonandtsconfig.node.json. Without-b,tscdoesn't follow references, so the step type-checks nothing and always passes.To check, I added a file with a deliberate error on
main:tsc --noEmit(currenttypecheck)tsc -bTS2322: Type 'string' is not assignable to type 'number'buildalready runstsc -b, but the build job is skipped on pull requests, so a type error would only surface after merging.Change
"typecheck": "tsc -b", the same checkbuildruns. Both referenced configs already setnoEmit: true, so nothing is emitted;tsc -bonly writes its.tsbuildinfofiles undernode_modules/.tmp/, asbuilddoes today.mainis clean under the real check (0 errors), so this doesn't turn CI red.Not in this PR
tsconfig.app.jsonincludessrcbut only a few files undertests/, so most test files still aren't type-checked. Widening that is a separate change and may surface existing errors.AI assistance disclosure
I made this change with help from Claude Code: it found the issue, verified both commands and drafted this description, and the change was reviewed before this PR was opened.